lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 476/667] OPP: call of_node_put() on error path in _bandwidth_supported()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 907ed123b9d096c73e9361f6cd4097f0691497f2 ]

    This code does not call of_node_put(opp_np) if of_get_next_available_child()
    returns NULL. But it should.

    Fixes: 45679f9b508f ("opp: Don't parse icc paths unnecessarily")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/opp/of.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/opp/of.c b/drivers/opp/of.c
    index c32ae7497392..3028353afece 100644
    --- a/drivers/opp/of.c
    +++ b/drivers/opp/of.c
    @@ -437,11 +437,11 @@ static int _bandwidth_supported(struct device *dev, struct opp_table *opp_table)

    /* Checking only first OPP is sufficient */
    np = of_get_next_available_child(opp_np, NULL);
    + of_node_put(opp_np);
    if (!np) {
    dev_err(dev, "OPP table empty\n");
    return -EINVAL;
    }
    - of_node_put(opp_np);

    prop = of_find_property(np, "opp-peak-kBps", NULL);
    of_node_put(np);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 21:54    [W:5.019 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site