lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.15 50/51] drm/amd/pm: use bitmap_{from,to}_arr32 where appropriate
    Date
    From: Yury Norov <yury.norov@gmail.com>

    [ Upstream commit 525d6515604eb1373ce5e6372a6b6640953b2d6a ]

    The smu_v1X_0_set_allowed_mask() uses bitmap_copy() to convert
    bitmap to 32-bit array. This may be wrong due to endiannes issues.
    Fix it by switching to bitmap_{from,to}_arr32.

    CC: Alexander Gordeev <agordeev@linux.ibm.com>
    CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    CC: Christian Borntraeger <borntraeger@linux.ibm.com>
    CC: Claudio Imbrenda <imbrenda@linux.ibm.com>
    CC: David Hildenbrand <david@redhat.com>
    CC: Heiko Carstens <hca@linux.ibm.com>
    CC: Janosch Frank <frankja@linux.ibm.com>
    CC: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    CC: Sven Schnelle <svens@linux.ibm.com>
    CC: Vasily Gorbik <gor@linux.ibm.com>
    Signed-off-by: Yury Norov <yury.norov@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 2 +-
    drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
    index 87b055466a33..e6c93396434f 100644
    --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
    +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
    @@ -772,7 +772,7 @@ int smu_v11_0_set_allowed_mask(struct smu_context *smu)
    goto failed;
    }

    - bitmap_copy((unsigned long *)feature_mask, feature->allowed, 64);
    + bitmap_to_arr32(feature_mask, feature->allowed, 64);

    ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_SetAllowedFeaturesMaskHigh,
    feature_mask[1], NULL);
    diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
    index 8d4aa16b2ae7..6211570fb64f 100644
    --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
    +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
    @@ -721,7 +721,7 @@ int smu_v13_0_set_allowed_mask(struct smu_context *smu)
    if (bitmap_empty(feature->allowed, SMU_FEATURE_MAX) || feature->feature_num < 64)
    goto failed;

    - bitmap_copy((unsigned long *)feature_mask, feature->allowed, 64);
    + bitmap_to_arr32(feature_mask, feature->allowed, 64);

    ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_SetAllowedFeaturesMaskHigh,
    feature_mask[1], NULL);
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-06-07 21:32    [W:2.793 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site