lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 392/667] PCI: mediatek: Fix refcount leak in mtk_pcie_subsys_powerup()
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 214e0d8fe4a813ae6ffd62bc2dfe7544c20914f4 ]

    The of_find_compatible_node() function returns a node pointer with
    refcount incremented, We should use of_node_put() on it when done
    Add the missing of_node_put() to release the refcount.

    Link: https://lore.kernel.org/r/20220309091953.5630-1-linmq006@gmail.com
    Fixes: 87e8657ba99c ("PCI: mediatek: Add new method to get shared pcie-cfg base address")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Reviewed-by: Miles Chen <miles.chen@mediatek.com>
    Acked-by: Rob Herring <robh@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/controller/pcie-mediatek.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c
    index 2f3f974977a3..5273cb5ede0f 100644
    --- a/drivers/pci/controller/pcie-mediatek.c
    +++ b/drivers/pci/controller/pcie-mediatek.c
    @@ -1008,6 +1008,7 @@ static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie)
    "mediatek,generic-pciecfg");
    if (cfg_node) {
    pcie->cfg = syscon_node_to_regmap(cfg_node);
    + of_node_put(cfg_node);
    if (IS_ERR(pcie->cfg))
    return PTR_ERR(pcie->cfg);
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 21:29    [W:2.776 / U:1.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site