lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 347/667] drm: msm: fix possible memory leak in mdp5_crtc_cursor_set()
    Date
    From: Hangyu Hua <hbh25y@gmail.com>

    [ Upstream commit 947a844bb3ebff0f4736d244d792ce129f6700d7 ]

    drm_gem_object_lookup will call drm_gem_object_get inside. So cursor_bo
    needs to be put when msm_gem_get_and_pin_iova fails.

    Fixes: e172d10a9c4a ("drm/msm/mdp5: Add hardware cursor support")
    Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
    Link: https://lore.kernel.org/r/20220509061125.18585-1-hbh25y@gmail.com
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
    index 477cda4ec23b..0e02e252ff89 100644
    --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
    +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
    @@ -989,8 +989,10 @@ static int mdp5_crtc_cursor_set(struct drm_crtc *crtc,

    ret = msm_gem_get_and_pin_iova(cursor_bo, kms->aspace,
    &mdp5_crtc->cursor.iova);
    - if (ret)
    + if (ret) {
    + drm_gem_object_put(cursor_bo);
    return -EINVAL;
    + }

    pm_runtime_get_sync(&pdev->dev);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 21:19    [W:4.125 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site