lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 344/667] regulator: scmi: Fix refcount leak in scmi_regulator_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 68d6c8476fd4f448e70e0ab31ff972838ac41dae ]

    of_find_node_by_name() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when done.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 0fbeae70ee7c ("regulator: add SCMI driver")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220516074433.32433-1-linmq006@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/regulator/scmi-regulator.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c
    index 1f02f60ad136..41ae7ac27ff6 100644
    --- a/drivers/regulator/scmi-regulator.c
    +++ b/drivers/regulator/scmi-regulator.c
    @@ -352,7 +352,7 @@ static int scmi_regulator_probe(struct scmi_device *sdev)
    return ret;
    }
    }
    -
    + of_node_put(np);
    /*
    * Register a regulator for each valid regulator-DT-entry that we
    * can successfully reach via SCMI and has a valid associated voltage
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 21:19    [W:4.075 / U:2.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site