lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 307/667] ASoC: imx-hdmi: Fix refcount leak in imx_hdmi_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit ed46731d8e86c8d65f5fc717671e1f1f6c3146d2 ]

    of_find_device_by_node() takes reference, we should use put_device()
    to release it. when devm_kzalloc() fails, it doesn't have a
    put_device(), it will cause refcount leak.
    Add missing put_device() to fix this.

    Fixes: 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver")
    Fixes: f670b274f7f6 ("ASoC: imx-hdmi: add put_device() after of_find_device_by_node()")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220511052740.46903-1-linmq006@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/fsl/imx-hdmi.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c
    index ef8d7a65ebc6..d61e3c841e26 100644
    --- a/sound/soc/fsl/imx-hdmi.c
    +++ b/sound/soc/fsl/imx-hdmi.c
    @@ -126,6 +126,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
    data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
    if (!data) {
    ret = -ENOMEM;
    + put_device(&cpu_pdev->dev);
    goto fail;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 21:11    [W:3.954 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site