lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 280/667] nl80211: dont hold RTNL in color change request
    Date
    From: Johannes Berg <johannes.berg@intel.com>

    [ Upstream commit 1b550a0bebfc0b69d6ec08fe6eb58953a8aec48a ]

    It's not necessary to hold the RTNL across color change
    requests, since all the inner locking needs only the
    wiphy mutex which we already hold as well.

    Fixes: 0d2ab3aea50b ("nl80211: add support for BSS coloring")
    Link: https://lore.kernel.org/r/20220414140402.32e03e8c261b.I5e7dc6bc563a129b938c43298da6bb4e812400a5@changeid
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/wireless/nl80211.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
    index dafa2c5b71a4..bb46a6a34614 100644
    --- a/net/wireless/nl80211.c
    +++ b/net/wireless/nl80211.c
    @@ -15936,8 +15936,7 @@ static const struct genl_small_ops nl80211_small_ops[] = {
    .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
    .doit = nl80211_color_change,
    .flags = GENL_UNS_ADMIN_PERM,
    - .internal_flags = NL80211_FLAG_NEED_NETDEV_UP |
    - NL80211_FLAG_NEED_RTNL,
    + .internal_flags = NL80211_FLAG_NEED_NETDEV_UP,
    },
    };

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 20:59    [W:4.026 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site