lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 235/667] media: i2c: max9286: Use dev_err_probe() helper
    Date
    From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

    [ Upstream commit df78b858e773967112b4444400fb7bb5bd7a9d8a ]

    Use the dev_err_probe() helper, instead of open-coding the same
    operation. While at it retrieve the error once and use it from
    'ret' instead of retrieving it twice.

    Link: https://lore.kernel.org/linux-media/20211208121756.3051565-1-niklas.soderlund+renesas@ragnatech.se
    Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: Niklas S\xF6derlund <niklas.soderlund+renesas@ragnatech.se>
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/max9286.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
    index 1aa2c58fd38c..1bbcc46fffd5 100644
    --- a/drivers/media/i2c/max9286.c
    +++ b/drivers/media/i2c/max9286.c
    @@ -1296,11 +1296,9 @@ static int max9286_probe(struct i2c_client *client)

    priv->regulator = devm_regulator_get(&client->dev, "poc");
    if (IS_ERR(priv->regulator)) {
    - if (PTR_ERR(priv->regulator) != -EPROBE_DEFER)
    - dev_err(&client->dev,
    - "Unable to get PoC regulator (%ld)\n",
    - PTR_ERR(priv->regulator));
    ret = PTR_ERR(priv->regulator);
    + dev_err_probe(&client->dev, ret,
    + "Unable to get PoC regulator\n");
    goto err_powerdown;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 20:47    [W:4.185 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site