lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 217/667] target: remove an incorrect unmap zeroes data deduction
    Date
    From: Christoph Hellwig <hch@lst.de>

    [ Upstream commit 179d8609d8424529e95021df939ed7b0b82b37f1 ]

    For block devices, the SCSI target drivers implements UNMAP as calls to
    blkdev_issue_discard, which does not guarantee zeroing just because
    Write Zeroes is supported.

    Note that this does not affect the file backed path which uses
    fallocate to punch holes.

    Fixes: 2237498f0b5c ("target/iblock: Convert WRITE_SAME to blkdev_issue_zeroout")
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
    Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
    Link: https://lore.kernel.org/r/20220415045258.199825-2-hch@lst.de
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/target/target_core_device.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
    index 44bb380e7390..fa866acef5bb 100644
    --- a/drivers/target/target_core_device.c
    +++ b/drivers/target/target_core_device.c
    @@ -850,7 +850,6 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
    attrib->unmap_granularity = q->limits.discard_granularity / block_size;
    attrib->unmap_granularity_alignment = q->limits.discard_alignment /
    block_size;
    - attrib->unmap_zeroes_data = !!(q->limits.max_write_zeroes_sectors);
    return true;
    }
    EXPORT_SYMBOL(target_configure_unmap_from_queue);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 20:47    [W:2.413 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site