lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 179/667] smb3: check for null tcon
    Date
    From: Steve French <stfrench@microsoft.com>

    [ Upstream commit bbdf6cf56c88845fb0b713cbf5c6623c53fe40d8 ]

    Although unlikely to be null, it is confusing to use a pointer
    before checking for it to be null so move the use down after
    null check.

    Addresses-Coverity: 1517586 ("Null pointer dereferences (REVERSE_INULL)")
    Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/cifs/smb2ops.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
    index df9ba3729d1f..775296e4d3c8 100644
    --- a/fs/cifs/smb2ops.c
    +++ b/fs/cifs/smb2ops.c
    @@ -745,8 +745,8 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon,
    struct cifs_sb_info *cifs_sb,
    struct cached_fid **cfid)
    {
    - struct cifs_ses *ses = tcon->ses;
    - struct TCP_Server_Info *server = ses->server;
    + struct cifs_ses *ses;
    + struct TCP_Server_Info *server;
    struct cifs_open_parms oparms;
    struct smb2_create_rsp *o_rsp = NULL;
    struct smb2_query_info_rsp *qi_rsp = NULL;
    @@ -764,6 +764,9 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon,
    if (tcon->nohandlecache)
    return -ENOTSUPP;

    + ses = tcon->ses;
    + server = ses->server;
    +
    if (cifs_sb->root == NULL)
    return -ENOENT;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 20:44    [W:4.300 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site