lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 119/667] media: ccs-core.c: fix failure to call clk_disable_unprepare
    Date
    From: Hans Verkuil <hverkuil-cisco@xs4all.nl>

    [ Upstream commit eca89cf60b040ee2cae693ea72a0364284f3084c ]

    Fixes smatch warning:

    drivers/media/i2c/ccs/ccs-core.c:1676 ccs_power_on() warn: 'sensor->ext_clk' from clk_prepare_enable() not released on lines: 1606.

    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/ccs/ccs-core.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
    index 5363f3bcafe3..67bb770ed63f 100644
    --- a/drivers/media/i2c/ccs/ccs-core.c
    +++ b/drivers/media/i2c/ccs/ccs-core.c
    @@ -1603,8 +1603,11 @@ static int ccs_power_on(struct device *dev)
    usleep_range(1000, 2000);
    } while (--retry);

    - if (!reset)
    - return -EIO;
    + if (!reset) {
    + dev_err(dev, "software reset failed\n");
    + rval = -EIO;
    + goto out_cci_addr_fail;
    + }
    }

    if (sensor->hwcfg.i2c_addr_alt) {
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 20:28    [W:4.128 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site