lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 448/452] RDMA/rxe: Generate a completion for unsupported/invalid opcode
    Date
    From: Xiao Yang <yangx.jy@fujitsu.com>

    commit 2f917af777011c88e977b9b9a5d00b280d3a59ce upstream.

    Current rxe_requester() doesn't generate a completion when processing an
    unsupported/invalid opcode. If rxe driver doesn't support a new opcode
    (e.g. RDMA Atomic Write) and RDMA library supports it, an application
    using the new opcode can reproduce this issue. Fix the issue by calling
    "goto err;".

    Fixes: 8700e3e7c485 ("Soft RoCE driver")
    Link: https://lore.kernel.org/r/20220410113513.27537-1-yangx.jy@fujitsu.com
    Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/infiniband/sw/rxe/rxe_req.c
    +++ b/drivers/infiniband/sw/rxe/rxe_req.c
    @@ -650,7 +650,7 @@ next_wqe:
    opcode = next_opcode(qp, wqe, wqe->wr.opcode);
    if (unlikely(opcode < 0)) {
    wqe->status = IB_WC_LOC_QP_OP_ERR;
    - goto exit;
    + goto err;
    }

    mask = rxe_opcode[opcode].mask;

    \
     
     \ /
      Last update: 2022-06-07 20:15    [W:2.106 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site