lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3 1/2] dt-bindings: leds: lp50xx: correct reg/unit addresses in example
Date
The multi-led node defined address/size cells, so it is intended to have
children with unit addresses.

The second multi-led's reg property defined three LED indexes within one
reg item, which is not correct - these are three separate items.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>

---

Changes since v2:
1. Minor grammar change in commit msg.
2. Add Rb tag.

Changes since v1:
1. Correct multi-led unit address as well (Rob).

Cc: Kyle Swenson <kyle.swenson@est.tech>
---
.../devicetree/bindings/leds/leds-lp50xx.yaml | 24 ++++++++++++-------
1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
index f12fe5b53f30..29ce0cb7d449 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
@@ -99,35 +99,41 @@ examples:
color = <LED_COLOR_ID_RGB>;
function = LED_FUNCTION_CHARGING;

- led-0 {
+ led@0 {
+ reg = <0x0>;
color = <LED_COLOR_ID_RED>;
};

- led-1 {
+ led@1 {
+ reg = <0x1>;
color = <LED_COLOR_ID_GREEN>;
};

- led-2 {
+ led@2 {
+ reg = <0x2>;
color = <LED_COLOR_ID_BLUE>;
};
};

- multi-led@2 {
+ multi-led@3 {
#address-cells = <1>;
- #size-cells = <2>;
- reg = <0x2 0x3 0x5>;
+ #size-cells = <0>;
+ reg = <0x3>, <0x4>, <0x5>;
color = <LED_COLOR_ID_RGB>;
function = LED_FUNCTION_STANDBY;

- led-6 {
+ led@3 {
+ reg = <0x3>;
color = <LED_COLOR_ID_RED>;
};

- led-7 {
+ led@4 {
+ reg = <0x4>;
color = <LED_COLOR_ID_GREEN>;
};

- led-8 {
+ led@5 {
+ reg = <0x5>;
color = <LED_COLOR_ID_BLUE>;
};
};
--
2.34.1
\
 
 \ /
  Last update: 2022-06-07 09:53    [W:0.916 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site