lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 240/452] thermal/drivers/broadcom: Fix potential NULL dereference in sr_thermal_probe
    Date
    From: Zheng Yongjun <zhengyongjun3@huawei.com>

    [ Upstream commit e20d136ec7d6f309989c447638365840d3424c8e ]

    platform_get_resource() may return NULL, add proper check to
    avoid potential NULL dereferencing.

    Fixes: 250e211057c72 ("thermal: broadcom: Add Stingray thermal driver")
    Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
    Link: https://lore.kernel.org/r/20220425092929.90412-1-zhengyongjun3@huawei.com
    Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/thermal/broadcom/sr-thermal.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/thermal/broadcom/sr-thermal.c b/drivers/thermal/broadcom/sr-thermal.c
    index 475ce2900771..85ab9edd580c 100644
    --- a/drivers/thermal/broadcom/sr-thermal.c
    +++ b/drivers/thermal/broadcom/sr-thermal.c
    @@ -60,6 +60,9 @@ static int sr_thermal_probe(struct platform_device *pdev)
    return -ENOMEM;

    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    + if (!res)
    + return -ENOENT;
    +
    sr_thermal->regs = (void __iomem *)devm_memremap(&pdev->dev, res->start,
    resource_size(res),
    MEMREMAP_WB);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 19:49    [W:4.232 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site