lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 163/452] scsi: ufs: qcom: Fix ufs_qcom_resume()
    Date
    From: Bart Van Assche <bvanassche@acm.org>

    [ Upstream commit bee40dc167da159ea5b939c074e1da258610a3d6 ]

    Clearing hba->is_sys_suspended if ufs_qcom_resume() succeeds is wrong. That
    variable must only be cleared if all actions involved in a resume succeed.
    Hence remove the statement that clears hba->is_sys_suspended from
    ufs_qcom_resume().

    Link: https://lore.kernel.org/r/20220419225811.4127248-23-bvanassche@acm.org
    Fixes: 81c0fc51b7a7 ("ufs-qcom: add support for Qualcomm Technologies Inc platforms")
    Tested-by: Bean Huo <beanhuo@micron.com>
    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Reviewed-by: Bean Huo <beanhuo@micron.com>
    Signed-off-by: Bart Van Assche <bvanassche@acm.org>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/ufs/ufs-qcom.c | 7 +------
    1 file changed, 1 insertion(+), 6 deletions(-)

    diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
    index 20182e39cb28..117740b302fa 100644
    --- a/drivers/scsi/ufs/ufs-qcom.c
    +++ b/drivers/scsi/ufs/ufs-qcom.c
    @@ -623,12 +623,7 @@ static int ufs_qcom_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
    return err;
    }

    - err = ufs_qcom_ice_resume(host);
    - if (err)
    - return err;
    -
    - hba->is_sys_suspended = false;
    - return 0;
    + return ufs_qcom_ice_resume(host);
    }

    static void ufs_qcom_dev_ref_clk_ctrl(struct ufs_qcom_host *host, bool enable)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 19:48    [W:3.981 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site