lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 147/452] EDAC/dmc520: Dont print an error for each unconfigured interrupt line
    Date
    From: Tyler Hicks <tyhicks@linux.microsoft.com>

    [ Upstream commit ad2df24732e8956a45a00894d2163c4ee8fb0e1f ]

    The dmc520 driver requires that at least one interrupt line, out of the
    ten possible, is configured. The driver prints an error and returns
    -EINVAL from its .probe function if there are no interrupt lines
    configured.

    Don't print a KERN_ERR level message for each interrupt line that's
    unconfigured as that can confuse users into thinking that there is an
    error condition.

    Before this change, the following KERN_ERR level messages would be
    reported if only dram_ecc_errc and dram_ecc_errd were configured in the
    device tree:

    dmc520 68000000.dmc: IRQ ram_ecc_errc not found
    dmc520 68000000.dmc: IRQ ram_ecc_errd not found
    dmc520 68000000.dmc: IRQ failed_access not found
    dmc520 68000000.dmc: IRQ failed_prog not found
    dmc520 68000000.dmc: IRQ link_err not
    dmc520 68000000.dmc: IRQ temperature_event not found
    dmc520 68000000.dmc: IRQ arch_fsm not found
    dmc520 68000000.dmc: IRQ phy_request not found

    Fixes: 1088750d7839 ("EDAC: Add EDAC driver for DMC520")
    Reported-by: Sinan Kaya <okaya@kernel.org>
    Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
    Signed-off-by: Borislav Petkov <bp@suse.de>
    Link: https://lore.kernel.org/r/20220111163800.22362-1-tyhicks@linux.microsoft.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/edac/dmc520_edac.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/edac/dmc520_edac.c b/drivers/edac/dmc520_edac.c
    index b8a7d9594afd..1fa5ca57e9ec 100644
    --- a/drivers/edac/dmc520_edac.c
    +++ b/drivers/edac/dmc520_edac.c
    @@ -489,7 +489,7 @@ static int dmc520_edac_probe(struct platform_device *pdev)
    dev = &pdev->dev;

    for (idx = 0; idx < NUMBER_OF_IRQS; idx++) {
    - irq = platform_get_irq_byname(pdev, dmc520_irq_configs[idx].name);
    + irq = platform_get_irq_byname_optional(pdev, dmc520_irq_configs[idx].name);
    irqs[idx] = irq;
    masks[idx] = dmc520_irq_configs[idx].mask;
    if (irq >= 0) {
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 19:47    [W:2.989 / U:1.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site