lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 233/452] ext4: reject the commit option on ext2 filesystems
    Date
    From: Eric Biggers <ebiggers@google.com>

    [ Upstream commit cb8435dc8ba33bcafa41cf2aa253794320a3b8df ]

    The 'commit' option is only applicable for ext3 and ext4 filesystems,
    and has never been accepted by the ext2 filesystem driver, so the ext4
    driver shouldn't allow it on ext2 filesystems.

    This fixes a failure in xfstest ext4/053.

    Fixes: 8dc0aa8cf0f7 ("ext4: check incompatible mount options while mounting ext2/3")
    Signed-off-by: Eric Biggers <ebiggers@google.com>
    Reviewed-by: Ritesh Harjani <ritesh.list@gmail.com>
    Reviewed-by: Lukas Czerner <lczerner@redhat.com>
    Link: https://lore.kernel.org/r/20220510183232.172615-1-ebiggers@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/ext4/super.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/ext4/super.c b/fs/ext4/super.c
    index 3e26edeca8c7..35d990adefc6 100644
    --- a/fs/ext4/super.c
    +++ b/fs/ext4/super.c
    @@ -1960,6 +1960,7 @@ static const struct mount_opts {
    MOPT_EXT4_ONLY | MOPT_CLEAR},
    {Opt_warn_on_error, EXT4_MOUNT_WARN_ON_ERROR, MOPT_SET},
    {Opt_nowarn_on_error, EXT4_MOUNT_WARN_ON_ERROR, MOPT_CLEAR},
    + {Opt_commit, 0, MOPT_NO_EXT2},
    {Opt_nojournal_checksum, EXT4_MOUNT_JOURNAL_CHECKSUM,
    MOPT_EXT4_ONLY | MOPT_CLEAR},
    {Opt_journal_checksum, EXT4_MOUNT_JOURNAL_CHECKSUM,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 19:45    [W:4.053 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site