lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 228/452] media: ov7670: remove ov7670_power_off from ov7670_remove
    Date
    From: Dongliang Mu <mudongliangabcd@gmail.com>

    [ Upstream commit 5bf19572e31375368f19edd2dbb2e0789518bb99 ]

    In ov7670_probe, it always invokes ov7670_power_off() no matter
    the execution is successful or failed. So we cannot invoke it
    agiain in ov7670_remove().

    Fix this by removing ov7670_power_off from ov7670_remove.

    Fixes: 030f9f682e66 ("media: ov7670: control clock along with power")
    Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/ov7670.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c
    index b42b289faaef..154776d0069e 100644
    --- a/drivers/media/i2c/ov7670.c
    +++ b/drivers/media/i2c/ov7670.c
    @@ -2000,7 +2000,6 @@ static int ov7670_remove(struct i2c_client *client)
    v4l2_async_unregister_subdev(sd);
    v4l2_ctrl_handler_free(&info->hdl);
    media_entity_cleanup(&info->sd.entity);
    - ov7670_power_off(sd);
    return 0;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 19:44    [W:2.542 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site