lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 133/452] drm/vc4: txp: Dont set TXP_VSTART_AT_EOF
    Date
    From: Maxime Ripard <maxime@cerno.tech>

    [ Upstream commit 234998df929f14d00cbf2f1e81a7facb69fd9266 ]

    The TXP_VSTART_AT_EOF will generate a second VSTART signal to the HVS.
    However, the HVS waits for VSTART to enable the FIFO and will thus start
    filling the FIFO before the start of the frame.

    This leads to corruption at the beginning of the first frame, and
    content from the previous frame at the beginning of the next frames.

    Since one VSTART is enough, let's get rid of it.

    Fixes: 008095e065a8 ("drm/vc4: Add support for the transposer block")
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
    Link: https://lore.kernel.org/r/20220328153659.2382206-3-maxime@cerno.tech
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/vc4/vc4_txp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c
    index d13502ae973d..d4e750cf3c02 100644
    --- a/drivers/gpu/drm/vc4/vc4_txp.c
    +++ b/drivers/gpu/drm/vc4/vc4_txp.c
    @@ -295,7 +295,7 @@ static void vc4_txp_connector_atomic_commit(struct drm_connector *conn,
    if (WARN_ON(i == ARRAY_SIZE(drm_fmts)))
    return;

    - ctrl = TXP_GO | TXP_VSTART_AT_EOF | TXP_EI |
    + ctrl = TXP_GO | TXP_EI |
    VC4_SET_FIELD(0xf, TXP_BYTE_ENABLE) |
    VC4_SET_FIELD(txp_fmts[i], TXP_FORMAT);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 19:37    [W:2.168 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site