lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 127/452] ASoC: mediatek: Fix error handling in mt8173_max98090_dev_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 4f4e0454e226de3bf4efd7e7924d1edc571c52d5 ]

    Call of_node_put(platform_node) to avoid refcount leak in
    the error path.

    Fixes: 94319ba10eca ("ASoC: mediatek: Use platform_of_node for machine drivers")
    Fixes: 493433785df0 ("ASoC: mediatek: mt8173: fix device_node leak")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Link: https://lore.kernel.org/r/20220404092903.26725-1-linmq006@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/mediatek/mt8173/mt8173-max98090.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/mediatek/mt8173/mt8173-max98090.c b/sound/soc/mediatek/mt8173/mt8173-max98090.c
    index 3bdd4931316c..5f39e810e27a 100644
    --- a/sound/soc/mediatek/mt8173/mt8173-max98090.c
    +++ b/sound/soc/mediatek/mt8173/mt8173-max98090.c
    @@ -167,7 +167,8 @@ static int mt8173_max98090_dev_probe(struct platform_device *pdev)
    if (!codec_node) {
    dev_err(&pdev->dev,
    "Property 'audio-codec' missing or invalid\n");
    - return -EINVAL;
    + ret = -EINVAL;
    + goto put_platform_node;
    }
    for_each_card_prelinks(card, i, dai_link) {
    if (dai_link->codecs->name)
    @@ -182,6 +183,8 @@ static int mt8173_max98090_dev_probe(struct platform_device *pdev)
    __func__, ret);

    of_node_put(codec_node);
    +
    +put_platform_node:
    of_node_put(platform_node);
    return ret;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-07 19:32    [W:2.356 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site