Messages in this thread Patch in this message | | | From | Rasmus Villemoes <> | Subject | [PATCH net-next] net: phy: fixed_phy: set phy_mask before calling mdiobus_register() | Date | Mon, 6 Jun 2022 22:02:08 +0200 |
| |
There's no point probing for phys on this artificial bus, so we can save a little bit of boot time by telling mdiobus_register() not to do that.
This doesn't have any functional change, since, at this point, fixed_mdio_read() returns 0xffff for all addresses/registers, so
mdiobus_scan() -> get_phy_device() -> get_phy_c22_id()
will return -ENODEV, which is just ignored.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- I was trying to debug something and got distracted by the printk() I added in get_phy_device() triggering 32 times in a row.
drivers/net/phy/fixed_phy.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c index 03abe6233bbb..aef739c20ac4 100644 --- a/drivers/net/phy/fixed_phy.c +++ b/drivers/net/phy/fixed_phy.c @@ -353,6 +353,7 @@ static int __init fixed_mdio_bus_init(void) fmb->mii_bus->parent = &pdev->dev; fmb->mii_bus->read = &fixed_mdio_read; fmb->mii_bus->write = &fixed_mdio_write; + fmb->mii_bus->phy_mask = ~0; ret = mdiobus_register(fmb->mii_bus); if (ret) -- 2.31.1
| |