Messages in this thread | | | Date | Mon, 6 Jun 2022 19:52:19 +0300 (EEST) | From | Ilpo Järvinen <> | Subject | Re: [PATCH v2 1/6] serial: 8250: Store to lsr_save_flags after lsr read |
| |
On Mon, 6 Jun 2022, Andy Shevchenko wrote:
> On Mon, Jun 6, 2022 at 3:55 PM Ilpo Järvinen > <ilpo.jarvinen@linux.intel.com> wrote: > > On Mon, 6 Jun 2022, Ilpo Järvinen wrote: > > ... > > > > Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250") > > > Link: https://lore.kernel.org/all/1d6c31d-d194-9e6a-ddf9-5f29af829f3@linux.intel.com/T/#m1737eef986bd20cf19593e344cebd7b0244945fc > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > Acked-by: Uwe Kleine-König <u.kleine-koenig@penugtronix.de> > > > > It seems that Uwe managed to mistype his email for the A-by which I just > > happily copy-pasted. > > > > Greg, please let me know if you want me to resend the series (or if you > > will just change it on the fly while applying). > > I believe Greg doesn't handle patches on the fly, hence resend. > But more importantly I do not see the reason for the Acked-by tag when > SoB of the same person is present.
I just repeated what Uwe gave me. Maybe he didn't notice he was already there as SoB.
This situation is anyway a bit more complex than usual. The line I took was part of Uwe's much larger patch initially (which was fully reverted) so his SoB was carried over to preserve the authorship. As I made a non-trivial modification to his original patch by removing almost all of it, I added my SoB too. Given this situation, I kind of thought he Acked (approved) the post-modification version of it.
-- i.
| |