Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 6 Jun 2022 19:01:15 +0200 | Subject | Re: [PATCH v2 1/6] serial: 8250: Store to lsr_save_flags after lsr read |
| |
On Mon, Jun 6, 2022 at 6:54 PM Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote: > On Mon, 6 Jun 2022, Andy Shevchenko wrote: > > On Mon, Jun 6, 2022 at 3:55 PM Ilpo Järvinen > > <ilpo.jarvinen@linux.intel.com> wrote:
...
> > But more importantly I do not see the reason for the Acked-by tag when > > SoB of the same person is present. > > I just repeated what Uwe gave me. Maybe he didn't notice he was already > there as SoB. > > This situation is anyway a bit more complex than usual. The line I took > was part of Uwe's much larger patch initially (which was fully reverted) > so his SoB was carried over to preserve the authorship. As I made a > non-trivial modification to his original patch by removing almost all of > it, I added my SoB too. Given this situation, I kind of thought he Acked > (approved) the post-modification version of it.
I believe you haven't preserved the authorship that way (since From line is different), but since you have done non-trivial changes and Uwe is okay with them, the straightforward tag chain would be (with your authorship implied): Co-developed-by: Uwe SoB: Uwe SoB: yours
-- With Best Regards, Andy Shevchenko
| |