[lkml]   [2022]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/3] ASoC: wm8940: Mute also the speaker output
    On Mon, Jun 06, 2022 at 05:44:41PM +0200, Lukasz Majewski wrote:

    > Without this change the BTL speaker produces some
    > "distortion" noise when test program
    > (speaker-test -t waw) is ended with ctrl+c.

    > As our design uses speaker outputs to drive BTL speaker,
    > it was necessary to also mute the speaker via the codec
    > internal WM8940_SPKVOL register with setting
    > WM8940_SPKMUTE bit.

    This will not interact well with both the user visible control of the
    speaker volume via the Speaker Playback Volume control and the analog
    bypass paths that the device has - it'll change the state of the control
    without generating any events, and cut off any bypassed audio that's
    mixed in.

    You can probably achieve a similar effect by making the control an
    _AUTODISABLE one which will allow the core to mute the control when it's
    not being used in a way that's not visible to userspace.
    [unhandled content-type:application/pgp-signature]
     \ /
      Last update: 2022-06-06 18:29    [W:3.205 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site