Messages in this thread | | | From | Hsin-Yi Wang <> | Date | Mon, 6 Jun 2022 23:25:39 +0800 | Subject | Re: [PATCH v3 4/8] drm/panel: lvds: Implement .get_orientation callback |
| |
On Mon, Jun 6, 2022 at 10:27 PM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > > > To return the orientation property to drm/kms driver. > > > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > --- > > v2->v3: add comments for notice. > > --- > > drivers/gpu/drm/panel/panel-lvds.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c > > index 27a1c9923b09..239527409b00 100644 > > --- a/drivers/gpu/drm/panel/panel-lvds.c > > +++ b/drivers/gpu/drm/panel/panel-lvds.c > > @@ -102,15 +102,29 @@ static int panel_lvds_get_modes(struct drm_panel *panel, > > connector->display_info.bus_flags = lvds->data_mirror > > ? DRM_BUS_FLAG_DATA_LSB_TO_MSB > > : DRM_BUS_FLAG_DATA_MSB_TO_LSB; > > Can you rebase your patch and send again? There's a context conflict > with the above line because your tree is lacking commit 83c784e70036 > ("drm/panel: lvds: Use bus_flags from DT panel-timing property") > Rebased in v4.
> In any case: > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |