Messages in this thread | | | From | Guenter Roeck <> | Date | Mon, 6 Jun 2022 08:24:20 -0700 | Subject | Re: [PATCH 04/13] platform/chrome: cros_ec_proto: assign buffer size from protocol info |
| |
On Mon, Jun 6, 2022 at 7:12 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > `din_size` is calculated from `ec_dev->max_response`. > `ec_dev->max_response` is further calculated from the protocol info. > > To make it clear, assign `din_size` and `dout_size` from protocol info > directly. > > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> --- > drivers/platform/chrome/cros_ec_proto.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c > index 65191af5139c..629dce3e6ab3 100644 > --- a/drivers/platform/chrome/cros_ec_proto.c > +++ b/drivers/platform/chrome/cros_ec_proto.c > @@ -449,12 +449,8 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev) > "using proto v%u\n", > ec_dev->proto_version); > > - ec_dev->din_size = ec_dev->max_response + > - sizeof(struct ec_host_response) + > - EC_MAX_RESPONSE_OVERHEAD; > - ec_dev->dout_size = ec_dev->max_request + > - sizeof(struct ec_host_request) + > - EC_MAX_REQUEST_OVERHEAD; > + ec_dev->din_size = proto_info->max_response_packet_size + EC_MAX_RESPONSE_OVERHEAD; > + ec_dev->dout_size = proto_info->max_request_packet_size + EC_MAX_REQUEST_OVERHEAD; > > /* > * Check for PD > -- > 2.36.1.255.ge46751e96f-goog >
| |