lkml.org 
[lkml]   [2022]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v5 0/3] Add nvmem support for dynamic partitions
    Date
    This very small series comes to fix the very annyoing problem of
    partitions declared by parser at runtime NOT supporting nvmem cells
    definition.

    The current implementation is very generic. The idea is to provide an of
    node if defined for everyone and not strictly limit this to nvmem stuff.
    But still the actual change is done only for nvmem-cells mtd. (just to
    make sure) This can totally change by removing the compatible check.

    The idea here is that a user can still use these dynamic parsers
    instead of declaring a fixed-partition and also declare how nvmem-cells
    are defined for the partition.
    This live with the assumption that dynamic partition have always the
    same name and they are known. (this is the case for smem-part partition
    that would require a bootloader reflash to change and for parsers like
    cmdlinepart where the name is always the same.)
    With this assumption, it's easy to fix this problem. Just introduce a
    new partition node that will declare just these special partition.
    Mtdcore then will check if these special declaration are present and
    connect the dynamic partition with the OF node present in the dts. Nvmem
    will automagically find the OF node and cells will be works based on the
    data provided by the parser.

    The initial idea was to create a special nvmem driver with a special
    compatible where a user would declare the mtd partition name and this
    driver would search it and register the nvmem cells but that became
    difficult really fast, mtd notifier system is problematic for this kind
    of stuff. So here is the better implementation. A variant of this is
    already tested on openwrt where we have devices that use cmdlinepart.
    (that current variant have defined in the dts the exact copy of
    cmdlinepart in the fixed-partition scheme and we patched the cmdlinepart
    parser to scan this fixed-partition node (that is ignored as cmdlinepart
    have priority) and connect the dynamic partition with the dts node)

    I provided an example of this in the documentation commit.
    In short it's needed to add to the partitions where the compatible parser
    is declared, a partition with just the label declared (instead of the reg).
    Then declare some nvmem-cells and it will all work at runtime.
    Mtdcore will check if a node with the same label is present and assign an
    OF node to the MTD.

    I currently tested this on my device that have smem-part and the
    gmac driver use nvmem to get the mac-address. This works correctly and
    the same address is provided.

    v5:
    - Simplify Documentation and move it generic partition.yaml
    - Split commit and move smem example to dedicated commit.
    v4:
    - Make it simple. No suffix. Make label mandatory again.
    - Update Documentation with new implementation.
    - Rename files to a better and correct name
    v3:
    - Fix warning from bot (function not declared as static)
    - Updated code to support also node name
    - Made partition label optional
    v2:
    - Simplify this. Drop dynamic-partition
    - Fix problem with parser with ko
    - Do not pollude mtd_get_of_node
    - Fix problem with Documentation

    Ansuel Smith (3):
    dt-bindings: mtd: partitions: Support label only partition
    dt-bindings: mtd: partitions: add additional example for
    qcom,smem-part
    mtd: core: introduce of support for dynamic partitions

    .../bindings/mtd/partitions/partition.yaml | 16 +++++-
    .../mtd/partitions/qcom,smem-part.yaml | 27 ++++++++++
    drivers/mtd/mtdcore.c | 49 +++++++++++++++++++
    3 files changed, 90 insertions(+), 2 deletions(-)

    --
    2.36.1

    \
     
     \ /
      Last update: 2022-06-06 17:15    [W:27.940 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site