lkml.org 
[lkml]   [2022]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 0/3] tracing/probes: allow no event name input when create group
    Hi Linyu,

    On Thu, 2 Jun 2022 20:10:58 +0800
    Linyu Yuan <quic_linyyuan@quicinc.com> wrote:

    > take kprobe event as example, when create a group of events,
    > p[:[GRP/]EVENT] [MOD:]KSYM[+OFFS]|KADDR [FETCHARGS],
    > according to this format, we must input EVENT name,
    >
    > this change allow only GRP/ input, EVENT name auto generate from KSYM,
    > p[:[GRP/][EVENT]] [MOD:]KSYM[+OFFS]|KADDR [FETCHARGS]
    >
    > siliar change apply to eprobe and uprobe.

    Thanks for updating the series. This looks godd to me.

    Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

    for this series.

    Thank you!

    >
    > V1: https://lore.kernel.org/lkml/1651397651-30454-1-git-send-email-quic_linyyuan@quicinc.com/
    >
    > V2: fix remove comment in V1 patch1,
    > remove v1 patch2 as it is NACK.
    >
    > v3: (v2 link: https://lore.kernel.org/lkml/1653795294-19764-1-git-send-email-quic_linyyuan@quicinc.com/)
    > add selftest cases for kprobe and eprobe event,
    > remove macro used in v1,v2,
    > change location to generate eprobe event name.
    >
    > v4: (v3 link: https://lore.kernel.org/lkml/1653978552-18637-1-git-send-email-quic_linyyuan@quicinc.com/)
    > fix comment of kprobe/eprobe test case.
    >
    > Linyu Yuan (3):
    > tracing: eprobe: remove duplicate is_good_name() operation
    > tracing: auto generate event name when create a group of events
    > selftests/ftrace: add test case for GRP/ only input
    >
    > Documentation/trace/kprobetrace.rst | 8 +++----
    > Documentation/trace/uprobetracer.rst | 8 +++----
    > kernel/trace/trace.c | 8 +++----
    > kernel/trace/trace_dynevent.c | 2 +-
    > kernel/trace/trace_eprobe.c | 25 +++++++++++-----------
    > kernel/trace/trace_kprobe.c | 16 ++++++++------
    > kernel/trace/trace_probe.c | 6 ++++++
    > kernel/trace/trace_uprobe.c | 12 +++++++----
    > .../ftrace/test.d/dynevent/add_remove_eprobe.tc | 9 +++++++-
    > .../ftrace/test.d/dynevent/add_remove_kprobe.tc | 7 ++++++
    > 10 files changed, 64 insertions(+), 37 deletions(-)
    >
    > --
    > 2.7.4
    >


    --
    Masami Hiramatsu (Google) <mhiramat@kernel.org>

    \
     
     \ /
      Last update: 2022-06-06 16:43    [W:3.910 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site