lkml.org 
[lkml]   [2022]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/3] dt-bindings: mfd: atmel,flexcom: Convert to json-schema
Date
> > Convert the Atmel flexcom device tree bindings to json schema.
> >
> > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> > ---
> > .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++
> > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------
> > 2 files changed, 97 insertions(+), 63 deletions(-)
> > create mode 100644
> Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
> flexcom.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> > new file mode 100644
> > index 000000000000..221bd840b49e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> > @@ -0,0 +1,97 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/atmel,flexcom.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Device tree bindings for Atmel Flexcom (Flexible Serial
> Communication Unit)
>
> There was a v2 of the same patch to which already commented. Now you
> send the same patch, without comments applied as v1. This does not make
> any sense.
>
> Please version your patches correctly and do not ignore received feedback.
>

Hi,

FYI, lan966x flexcom chip-select driver support is moved to atmel-flexcom.c rather than
implementing a new mux driver. So, I sent new version now with driver changes in drives/mfd/atmel-flexcom.c
I once again gone through your v2 comments. I missed this comment "s/Device tree bindings//".
Except that I addressed remaining all other comments for dt-bindings patches.
>
> Best regards,
> Krzysztof
\
 
 \ /
  Last update: 2022-06-06 15:30    [W:0.103 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site