[lkml]   [2022]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RESEND PATCH] scsi: ufs: sysfs: support writing boot_lun attr
On 6/5/22 19:48, Damien Le Moal wrote:
> On 6/5/22 12:55, Bart Van Assche wrote:
>> On 6/1/22 10:05, Avri Altman wrote:
>>> As a design rule, sysfs attribute files should not be used to make
>>> persistent modifications to a device configuration. This rule applies
>>> to all subsystems and ufs is no different.
>> Hmm ... where does that rule come from? I can't find it in
>> Documentation/admin-guide/sysfs-rules.rst. Did I perhaps overlook something?
> I am not aware of any writable sysfs attribute file that can be used to
> make persistent device configuration changes, at least in storage area.
> I know of plenty that do change a device setting, but without saving this
> setting to maintain it across power cycles. Do you know of any such
> attribute ? I was under the impression that sysfs should not be used to
> persistently reconfigure a device...

I don't think the above is sufficient as an argument to reject a new
patch that introduces a sysfs attribute that changes the device



 \ /
  Last update: 2022-06-06 15:17    [W:0.126 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site