lkml.org 
[lkml]   [2022]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8192u: Fix sleep in atomic context bug in dm_fsync_timer_callback
On Fri, May 20, 2022 at 02:15:41PM +0800, Duoming Zhou wrote:
> There are sleep in atomic context bugs when dm_fsync_timer_callback is
> executing. The root cause is that the memory allocation functions with
> GFP_KERNEL parameter are called in dm_fsync_timer_callback which is a
> timer handler. The call paths that could trigger bugs are shown below:
>
> (interrupt context)
> dm_fsync_timer_callback
> write_nic_byte
> kzalloc(sizeof(data), GFP_KERNEL); //may sleep
> write_nic_dword
> kzalloc(sizeof(data), GFP_KERNEL); //may sleep
>
> This patch changes allocation mode from GFP_KERNEL to GFP_ATOMIC
> in order to prevent atomic context sleeping. The GFP_ATOMIC flag
> makes memory allocation operation could be used in atomic context.
>
> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>

What commit id does this fix?

And how did you find this issue? Did you run the code to verify it
still works properly?

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-06-06 07:44    [W:0.772 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site