Messages in this thread | | | Date | Mon, 6 Jun 2022 12:46:08 +0200 | Subject | Re: [PATCH 1/1] nfc: nfcmrvl: Fix memory leak in nfcmrvl_play_deferred | From | Krzysztof Kozlowski <> |
| |
On 05/06/2022 10:14, Xiaohui Zhang wrote: > From: xiaohuizhang98 <ruc_zhangxiaohui@163.com> > > We detected a suspected bug with our code clone detection tool. > > Similar to the handling of play_deferred in commit 19cfe912c37b > ("Bluetooth: btusb: Fix memory leak in play_deferred"), we thought > a patch might be needed here as well. > > Currently usb_submit_urb is called directly to submit deferred tx > urbs after unanchor them. > > So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb > and cause memory leak. > > Put those urbs in tx_anchor to avoid the leak, and also fix the error > handling. > > Signed-off-by: xiaohuizhang98 <ruc_zhangxiaohui@163.com>
This name still does not match your name used in email.
Best regards, Krzysztof
| |