Messages in this thread | | | Date | Mon, 6 Jun 2022 13:37:41 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 4/4] cpumask: Update cpumask_next_wrap() signature |
| |
On Sun, Jun 05, 2022 at 08:22:41AM +0200, Sander Vanheule wrote: > The extern specifier is not needed for this declaration, so drop it. The > function also depends only on the input parameters, and has no side > effects, so it can be marked __pure like other functions in cpumask.h
Missed period.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Sander Vanheule <sander@svanheule.net> > --- > include/linux/cpumask.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h > index 7ccddbc27ac3..f37ce00741a3 100644 > --- a/include/linux/cpumask.h > +++ b/include/linux/cpumask.h > @@ -210,7 +210,7 @@ int cpumask_any_distribute(const struct cpumask *srcp); > (cpu) = cpumask_next_zero((cpu), (mask)), \ > (cpu) < nr_cpu_ids;) > > -extern int cpumask_next_wrap(int n, const struct cpumask *mask, int start, bool wrap); > +int __pure cpumask_next_wrap(int n, const struct cpumask *mask, int start, bool wrap); > > /** > * for_each_cpu_wrap - iterate over every cpu in a mask, starting at a specified location > -- > 2.36.1 >
-- With Best Regards, Andy Shevchenko
| |