Messages in this thread | | | From | Muchun Song <> | Date | Tue, 7 Jun 2022 11:55:39 +0800 | Subject | Re: [PATCH] tcp: use kvmalloc_array() to allocate table_perturb |
| |
On Tue, Jun 7, 2022 at 12:13 AM Eric Dumazet <edumazet@google.com> wrote: > > On Mon, Jun 6, 2022 at 9:05 AM Eric Dumazet <edumazet@google.com> wrote: > > > > On Mon, Jun 6, 2022 at 12:08 AM Muchun Song <songmuchun@bytedance.com> wrote: > > > > > > In our server, there may be no high order (>= 6) memory since we reserve > > > lots of HugeTLB pages when booting. Then the system panic. So use > > > kvmalloc_array() to allocate table_perturb. > > > > > > Signed-off-by: Muchun Song <songmuchun@bytedance.com> > > > > Please add a Fixes: tag and CC original author ? > >
Will do.
> > Thanks. > > Also using alloc_large_system_hash() might be a better option anyway, > spreading pages on multiple nodes on NUMA hosts.
Using alloc_large_system_hash() LGTM, but I didn't see where the memory is allocated on multi-node in alloc_large_system_hash() or vmalloc_huge(), what I missed here?
Thanks.
| |