lkml.org 
[lkml]   [2022]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v10 03/21] drm/edid: Convert cea_sad helper struct to kernelDoc
    From
    Date
    On Wed, 2022-05-25 at 14:01 +0200, AngeloGioacchino Del Regno wrote:
    > Il 23/05/22 12:47, Guillaume Ranquet ha scritto:
    > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
    > > ---
    > > include/drm/drm_edid.h | 12 +++++++++---
    > > 1 file changed, 9 insertions(+), 3 deletions(-)
    > >
    > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
    > > index 144c495b99c4..37c420423625 100644
    > > --- a/include/drm/drm_edid.h
    > > +++ b/include/drm/drm_edid.h
    > > @@ -359,12 +359,18 @@ struct edid {
    > >
    > > #define EDID_PRODUCT_ID(e) ((e)->prod_code[0] | ((e)-
    > > >prod_code[1] << 8))
    > >
    > > -/* Short Audio Descriptor */
    > > +/**
    > > + * struct cea_sad - Short Audio Descriptor.
    >
    > Perhaps....
    >
    > * struct cea_sad - CEA Short Audio Descriptor
    >
    > ...but that's relative to personal liking and nothing else, it's also
    > fine as
    > it is, if you like it more as it is. The ball is yours :-P
    >
    > Regardless of any choice about changing the description or not:
    >
    > Reviewed-by: AngeloGioacchino Del Regno <
    > angelogioacchino.delregno@collabora.com>
    >
    > Cheers,
    > Angelo
    >

    Hello Angelo,

    ok, I will do this in next version.

    BRs,
    Bo-Chen

    > > + * @format: See HDMI_AUDIO_CODING_TYPE_*.
    > > + * @channels: max number of channels - 1.
    > > + * @freq: See CEA_SAD_FREQ_*.
    > > + * @byte2: meaning depends on format.
    > > + */
    > > struct cea_sad {
    > > u8 format;
    > > - u8 channels; /* max number of channels - 1 */
    > > + u8 channels;
    > > u8 freq;
    > > - u8 byte2; /* meaning depends on format */
    > > + u8 byte2;
    > > };
    > >
    > > struct drm_encoder;
    >
    >
    > _______________________________________________
    > Linux-mediatek mailing list
    > Linux-mediatek@lists.infradead.org
    > http://lists.infradead.org/mailman/listinfo/linux-mediatek

    \
     
     \ /
      Last update: 2022-06-07 04:46    [W:4.048 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site