lkml.org 
[lkml]   [2022]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] remoteproc: k3-r5: Fix refcount leak in k3_r5_cluster_of_init
From
Hi Miaoqian,

On 6/5/22 03:33, Miaoqian Lin wrote:
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node.
> When breaking early from a for_each_available_child_of_node() loop,
> we need to explicitly call of_node_put() on the child node.
> Add missing of_node_put() to avoid refcount leak.

Thanks for catching this.

>
> Fixes: 6dedbd1d5443 ("remoteproc: k3-r5: Add a remoteproc driver for R5F subsystem")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Acked-by: Suman Anna <s-anna@ti.com>

regards
Suman

> ---
> drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> index 4840ad906018..0481926c6975 100644
> --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> @@ -1655,6 +1655,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)
> if (!cpdev) {
> ret = -ENODEV;
> dev_err(dev, "could not get R5 core platform device\n");
> + of_node_put(child);
> goto fail;
> }
>
> @@ -1663,6 +1664,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)
> dev_err(dev, "k3_r5_core_of_init failed, ret = %d\n",
> ret);
> put_device(&cpdev->dev);
> + of_node_put(child);
> goto fail;
> }
>

\
 
 \ /
  Last update: 2022-06-07 03:23    [W:0.243 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site