Messages in this thread | | | Date | Tue, 7 Jun 2022 00:54:59 +0000 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH 07/13] platform/chrome: cros_ec_proto: separate fill_protocol_info() |
| |
On Mon, Jun 06, 2022 at 09:06:03AM -0700, Guenter Roeck wrote: > On Mon, Jun 6, 2022 at 7:12 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > -static int cros_ec_host_command_proto_query(struct cros_ec_device *ec_dev, > > - int devidx, > > - struct cros_ec_command *msg) > > +static int fill_protocol_info(struct cros_ec_device *ec_dev, int devidx) > > I would suggest to keep the cros_ec_ prefix. Also, "fill" sounds a bit > too much as if the function would fill some structure fields. "get" > (ie cros_ec_get_proto_info or similar) might be a better name,
Ack, will fix in next version.
| |