Messages in this thread | | | Date | Mon, 6 Jun 2022 22:50:57 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation |
| |
Hi Hans,
> > Please move this up so it is together with the other get_* methods, in > > alphabetic order. That is, right after get_modes(), and then this also > > matches the order in the .c file with is extra bonus. > > The downside of moving this up is that it will break drivers which don't > use c99 style named-struct-field initializers for there drm_panel_funcs. > > I admit that no drivers should be using the old style struct init, but > are we sure that that is the case?
There is no in-tree driver that uses old style struct init for drm_panel_funcs - so we are safe here.
I just did a quick git grep -A 4 drm_panel_funcs to verify it, browsing through the output did not reveal any old style users.
Sam
| |