lkml.org 
[lkml]   [2022]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sparc32,leon: Fix reference leak in leon_ipi_init
On Sun, Jun 05, 2022 at 09:29:41AM +0400, Miaoqian Lin wrote:
> of_find_node_by_path() returns a node pointer with
> refcount incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 1ca0c808c60f ("sparc32,leon: Implemented SMP IPIs for LEON CPU")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

The patch is finei, thanks:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

All other uses of of_find_node_by_path() in sparc has the same issue.
Could you try to take a look at the rest too?

Sam
> ---
> arch/sparc/kernel/leon_smp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sparc/kernel/leon_smp.c b/arch/sparc/kernel/leon_smp.c
> index 1eed26d423fb..85b22669c002 100644
> --- a/arch/sparc/kernel/leon_smp.c
> +++ b/arch/sparc/kernel/leon_smp.c
> @@ -284,6 +284,7 @@ static void __init leon_ipi_init(void)
> pp = of_find_property(rootnp, "ipi_num", &len);
> if (pp && (*(int *)pp->value))
> leon_ipi_irq = *(int *)pp->value;
> + of_node_put(rootnp);
> }
> printk(KERN_INFO "leon: SMP IPIs at IRQ %d\n", leon_ipi_irq);
>
> --
> 2.25.1

\
 
 \ /
  Last update: 2022-06-05 09:49    [W:0.045 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site