Messages in this thread Patch in this message | | | From | cgel.zte@gmail ... | Subject | [PATCH] [media] si2165: Remove redundant NULL check before release_firmware() call | Date | Mon, 6 Jun 2022 01:44:33 +0000 |
| |
From: Minghao Chi <chi.minghao@zte.com.cn>
release_firmware() checks for NULL pointers internally so checking before calling it is redundant.
Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> --- drivers/media/dvb-frontends/si2165.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index ebee230afb7b..3d167ca670a4 100644 --- a/drivers/media/dvb-frontends/si2165.c +++ b/drivers/media/dvb-frontends/si2165.c @@ -513,10 +513,8 @@ static int si2165_upload_firmware(struct si2165_state *state) ret = 0; state->firmware_loaded = true; error: - if (fw) { - release_firmware(fw); - fw = NULL; - } + release_firmware(fw); + fw = NULL; return ret; } -- 2.25.1
| |