Messages in this thread | | | Date | Sun, 5 Jun 2022 12:55:40 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH bpf-next 2/3] ftrace: Keep address offset in ftrace_lookup_symbols |
| |
On Mon, 30 May 2022 22:20:12 +0200 Daniel Borkmann <daniel@iogearbox.net> wrote:
> On 5/27/22 10:56 PM, Jiri Olsa wrote: > > We want to store the resolved address on the same index as > > the symbol string, because that's the user (bpf kprobe link) > > code assumption. > > > > Also making sure we don't store duplicates that might be > > present in kallsyms. > > > > Fixes: bed0d9a50dac ("ftrace: Add ftrace_lookup_symbols function") > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > --- > > kernel/trace/ftrace.c | 13 +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > Steven / Masami, would be great to get an Ack from one of you before applying.
I just don't care for the unnecessary "0x" in the memset, but other than that:
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
| |