Messages in this thread | | | Date | Sun, 5 Jun 2022 17:12:42 +0200 | Subject | Re: [RFC PATCH 1/2] dt-bindings: input: gpio-keys: enforce node names to match all properties | From | Krzysztof Kozlowski <> |
| |
On 04/06/2022 05:04, Jeff LaBundy wrote: >> - dependencies: >> - wakeup-event-action: [ wakeup-source ] >> - linux,input-value: [ gpios ] >> - >> - unevaluatedProperties: false >> + "^(key|key-[a-z0-9-]+|[a-z0-9-]+-key)$": > > Maybe this would be better as: > > "^((key|switch|axis)|(key|switch|axis)-[a-z0-9-]+|[a-z0-9-]+-(key|switch|axis))$": > > ...or perhaps a more efficient version of my counter-proposal. > > The reason is because it is confusing to see a lid or dock switch named > as "key-lid", etc.
Nice point. "switch" I understand, but can you really have "axis" on GPIO keys? I had impression axis is related to joysticks.
Best regards, Krzysztof
| |