| Subject | Re: [PATCH v3 09/33] lib/printbuf: Unit specifiers | From | Joe Perches <> | Date | Sat, 04 Jun 2022 18:06:37 -0700 |
| |
On Sat, 2022-06-04 at 15:30 -0400, Kent Overstreet wrote: > This adds options to printbuf for specifying whether units should be > printed raw (default) or with human readable units, and for controlling > whether human-readable units should be base 2 (default), or base 10. [] > > This also adds new helpers that obey these options: > > - pr_human_readable_u64 > - pr_human_readable_s64
Mismatched between commit message and code
> diff --git a/include/linux/printbuf.h b/include/linux/printbuf.h [] > @@ -53,10 +53,19 @@ [] > +void prt_human_readable_u64(struct printbuf *, u64); > +void prt_human_readable_s64(struct printbuf *, s64);
etc...
I think pb_ a better prefix
|