lkml.org 
[lkml]   [2022]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 14/17] perf c2c: Refactor display string
    Date
    The display type is shown by combination the display string array and a
    suffix string "HITMs", which is not friendly to extend display for other
    sorting type (e.g. extension for peer operations).

    This patch moves the suffix string "HITMs" into display string array for
    HITM types, so it can allow us to not necessarily to output string
    "HITMs" for new incoming display type.

    Signed-off-by: Leo Yan <leo.yan@linaro.org>
    Acked-by: Ian Rogers <irogers@google.com>
    Tested-by: Ali Saidi <alisaidi@amazon.com>
    Reviewed-by: Ali Saidi <alisaidi@amazon.com>
    ---
    tools/perf/builtin-c2c.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
    index 49a9b8480b41..8b7c1fd35380 100644
    --- a/tools/perf/builtin-c2c.c
    +++ b/tools/perf/builtin-c2c.c
    @@ -122,9 +122,9 @@ enum {
    };

    static const char *display_str[DISPLAY_MAX] = {
    - [DISPLAY_LCL_HITM] = "Local",
    - [DISPLAY_RMT_HITM] = "Remote",
    - [DISPLAY_TOT_HITM] = "Total",
    + [DISPLAY_LCL_HITM] = "Local HITMs",
    + [DISPLAY_RMT_HITM] = "Remote HITMs",
    + [DISPLAY_TOT_HITM] = "Total HITMs",
    };

    static const struct option c2c_options[] = {
    @@ -2489,7 +2489,7 @@ static void print_c2c_info(FILE *out, struct perf_session *session)
    fprintf(out, "%-36s: %s\n", first ? " Events" : "", evsel__name(evsel));
    first = false;
    }
    - fprintf(out, " Cachelines sort on : %s HITMs\n",
    + fprintf(out, " Cachelines sort on : %s\n",
    display_str[c2c.display]);
    fprintf(out, " Cacheline data grouping : %s\n", c2c.cl_sort);
    }
    @@ -2646,7 +2646,7 @@ static int perf_c2c_browser__title(struct hist_browser *browser,
    {
    scnprintf(bf, size,
    "Shared Data Cache Line Table "
    - "(%lu entries, sorted on %s HITMs)",
    + "(%lu entries, sorted on %s)",
    browser->nr_non_filtered_entries,
    display_str[c2c.display]);
    return 0;
    --
    2.25.1
    \
     
     \ /
      Last update: 2022-06-04 06:31    [W:4.752 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site