lkml.org 
[lkml]   [2022]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v4 2/7] can: Kconfig: turn menu "CAN Device Drivers" into a menuconfig using CAN_DEV
    My previous mail on this was wrong (as you noticed).... so here's the
    corrected one (hopefully).

    On 03.06.2022 19:28:43, Vincent Mailhol wrote:
    > diff --git a/drivers/net/can/dev/Makefile b/drivers/net/can/dev/Makefile
    > index 5b4c813c6222..919f87e36eed 100644
    > --- a/drivers/net/can/dev/Makefile
    > +++ b/drivers/net/can/dev/Makefile
    > @@ -1,9 +1,11 @@
    > # SPDX-License-Identifier: GPL-2.0
    >
    > -obj-$(CONFIG_CAN_NETLINK) += can-dev.o
    > -can-dev-y += bittiming.o
    > -can-dev-y += dev.o
    > -can-dev-y += length.o
    > -can-dev-y += netlink.o
    > -can-dev-y += rx-offload.o
    > -can-dev-y += skb.o
    > +obj-$(CONFIG_CAN_DEV) += can-dev.o
    > +
    > +can-dev-$(CONFIG_CAN_DEV) += skb.o
    ^^^^^^^^^^^^^^^^

    As "skb.o" is always part of "can-dev.o" (if build at all), you can use
    "can-dev-y" here.

    Marc

    --
    Pengutronix e.K. | Marc Kleine-Budde |
    Embedded Linux | https://www.pengutronix.de |
    Vertretung West/Dortmund | Phone: +49-231-2826-924 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2022-06-04 15:46    [W:4.068 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site