Messages in this thread | | | Date | Thu, 30 Jun 2022 20:47:46 +0530 | Subject | Re: [PATCH v3 4/4] drm/msm/adreno: Fix up formatting | From | Akhil P Oommen <> |
| |
On 5/28/2022 10:22 PM, Joe Perches wrote: > On Sat, 2022-05-28 at 18:03 +0200, Konrad Dybcio wrote: >> Leading spaces are not something checkpatch likes, and it says so when >> they are present. Use tabs consistently to indent function body and >> unwrap a 83-char-long line, as 100 is cool nowadays. > unassociated trivia: > >> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h > [] >> @@ -199,7 +199,7 @@ static inline int adreno_is_a420(struct adreno_gpu *gpu) >> >> static inline int adreno_is_a430(struct adreno_gpu *gpu) >> { >> - return gpu->revn == 430; >> + return gpu->revn == 430; >> } > looks like these could/should return bool But this is just a format fix.
> >> static inline int adreno_is_a506(struct adreno_gpu *gpu) >> @@ -239,7 +239,7 @@ static inline int adreno_is_a540(struct adreno_gpu *gpu) >> >> static inline int adreno_is_a618(struct adreno_gpu *gpu) >> { >> - return gpu->revn == 618; >> + return gpu->revn == 618; >> } > etc...
Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
-Akhil.
| |