Messages in this thread | | | Date | Thu, 30 Jun 2022 10:36:03 +0200 | Subject | Re: [PATCH v1 1/9] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc | From | Hans de Goede <> |
| |
Hi,
On 6/30/22 10:07, Andy Shevchenko wrote: > On Thu, Jun 30, 2022 at 10:01 AM Lee Jones <lee.jones@linaro.org> wrote: >> On Wed, 29 Jun 2022, Andy Shevchenko wrote: >>> On Wed, Jun 29, 2022 at 4:36 PM Lee Jones <lee.jones@linaro.org> wrote: >>>> On Tue, 28 Jun 2022, Andy Shevchenko wrote:> > On Mon, Jun 27, 2022 at 02:08:39PM +0100, Lee Jones wrote: >>>>>> On Thu, 16 Jun 2022, Andy Shevchenko wrote: > > ... > >>>>>>> drivers/mfd/intel_soc_pmic_core.c | 160 ----------------------------- >>>>>>> drivers/mfd/intel_soc_pmic_core.h | 25 ----- >>>>>>> drivers/mfd/intel_soc_pmic_crc.c | 162 ++++++++++++++++++++++++++++-- >>>>>>> 4 files changed, 157 insertions(+), 193 deletions(-) >>>>>>> delete mode 100644 drivers/mfd/intel_soc_pmic_core.c >>>>>>> delete mode 100644 drivers/mfd/intel_soc_pmic_core.h >>>>>> >>>>>> Can you submit this again with the -M flag please. >>>>> >>>>> This is done with this flag. Basically for the last several years I do my >>>>> submissions with that flag. >>>> >>>> Odd. I thought -M only showed diff for the changes. >>> >>> It's exactly what happens here in this patch. What did I miss? >>> >>> Note here is not renaming, but merging contents of one file (actually >>> two files) into another. What you are talking about is probably -D, >>> but AFAIR Git (at least that time) can't catch up deleted files from >>> the mbox format. That's why I do not use -D for submissions. >> >> Ah yes, that's probably it then. >> >> From a quick look at the diff (I missed the 2 "--" at the end), it >> looked like this was a rename. In which case -M won't do anything >> useful here. I'll have to brain grep the differences instead. > > Please do, it will be good to have this double checked.
Note that I already did a manual compare of the moved code blocks to check that they were not changed before giving my Reviewed-by.
Regards,
Hans
| |