Messages in this thread | | | From | "Tian, Kevin" <> | Subject | RE: [PATCH v1 2/6] iommu/vt-d: Use IDA interface to manage iommu sequence id | Date | Thu, 30 Jun 2022 08:21:51 +0000 |
| |
> From: Lu Baolu <baolu.lu@linux.intel.com> > Sent: Saturday, June 25, 2022 8:52 PM > > @@ -1062,11 +1040,14 @@ static int alloc_iommu(struct dmar_drhd_unit > *drhd) > if (!iommu) > return -ENOMEM; > > - if (dmar_alloc_seq_id(iommu) < 0) { > + iommu->seq_id = ida_alloc_range(&dmar_seq_ids, 0, > + DMAR_UNITS_SUPPORTED,
should be "DMAR_UNITS_SUPPORTED - 1"
> GFP_KERNEL); > + if (iommu->seq_id < 0) { > pr_err("Failed to allocate seq_id\n"); > err = -ENOSPC; > goto error; > }
ida_alloc_range() returns error code already. No need to change it.
| |