Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 30 Jun 2022 09:56:11 +0200 | Subject | Re: [PATCH v1 1/1] serial: 8250_dw: Drop PM ifdeffery |
| |
On Thu, Jun 30, 2022 at 9:42 AM Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote: > > On Wed, 29 Jun 2022, Andy Shevchenko wrote: > > > Drop CONFIG_PM and CONFIG_PM_SLEEP ifdeffery while converting dw8250_pm_ops > > to use new PM macros. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > > Not directily related to the patch itself but do you have any idea why > 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones") > didn't wrap RUNTIME_PM_OPS() pointers with pm_ptr()? I'm asking this > because in SET_RUNTIME_PM_OPS() the callbacks are only created with > #ifdef CONFIG_PM so I'd have expected RUNTIME_PM_OPS() to maintain that > behavior but it didn't? Was it just an oversight that should be fixed?
I have had the same question, but I think it might be related to how PM runtime functions when there is no respective configuration option set.
+Cc: Rafael.
-- With Best Regards, Andy Shevchenko
| |