Messages in this thread | | | Date | Thu, 30 Jun 2022 16:27:00 -0600 | From | Rob Herring <> | Subject | Re: [PATCH] dt-bindings: leds: class-multicolor: reference class directly in multi-led node |
| |
On Fri, 24 Jun 2022 13:21:06 +0200, Krzysztof Kozlowski wrote: > The leds/common.yaml is referenced directly in each LED node, which > leads to people doing the same with leds/leds-class-multicolor.yaml. > This is not correct because leds-class-multicolor.yaml defined multi-led > property and its children. Some schemas implemented this incorrect. > > Rework this to match same behavior common.yaml, so expect the multi-led > node to reference the leds-class-multicolor.yaml. Fixing allows to add > unevaluatedProperties:false. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > This will conflict with any new users of leds-class-multicolor, e.g.: > https://lore.kernel.org/all/20220623115631.22209-4-peterwu.pub@gmail.com/ > > The new users should be updated to match the usage introduced here. > --- > .../leds/cznic,turris-omnia-leds.yaml | 2 ++ > .../bindings/leds/leds-class-multicolor.yaml | 32 +++++++++---------- > .../devicetree/bindings/leds/leds-lp50xx.yaml | 2 ++ > .../bindings/leds/leds-pwm-multicolor.yaml | 5 ++- > .../bindings/leds/leds-qcom-lpg.yaml | 2 ++ > 5 files changed, 24 insertions(+), 19 deletions(-) >
Reviewed-by: Rob Herring <robh@kernel.org>
| |